CC-519: Add structured reviewer coverage and finding contracts - #456
Merged
Conversation
screenleon
marked this pull request as ready for review
July 30, 2026 01:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
gate_reviewer_result_v1schema with a closed verdict vocabulary, complete coverage declarations, stable actionable findings, and scope-bound evidence referencespr_gate_result_v3Why
Reviewer completion was coupled to Markdown heading formatting, so duplicated or omitted prose could turn a substantively complete review into a protocol failure. Reviewer outputs also lacked one deterministic contract for coverage, evidence, findings, and aggregate verdict parity.
Impact
Selected reviewers now produce machine-verifiable, scope-bound results. Protocol defects fail closed as
INCOMPLETE, while actual reviewer verdicts remain distinct and deterministic across sequential and parallel execution.Validation
bash tests/bin/run-all-tests.sh: PASS — 97 passed, 0 failed, 0 skippedbash tests/bin/run-tests.sh --verify-full .pm-dispatch/test-results/latest-full.json: verified authoritative full PASS for the committed treegit diff --check: PASS