Skip to content

CC-519: Add structured reviewer coverage and finding contracts - #456

Merged
screenleon merged 1 commit into
mainfrom
feat/CC-519
Jul 30, 2026
Merged

CC-519: Add structured reviewer coverage and finding contracts#456
screenleon merged 1 commit into
mainfrom
feat/CC-519

Conversation

@screenleon

Copy link
Copy Markdown
Owner

What changed

  • add the gate_reviewer_result_v1 schema with a closed verdict vocabulary, complete coverage declarations, stable actionable findings, and scope-bound evidence references
  • extend current scope manifests with an immutable reviewer reference index and enforce path, digest, and line-bound validation before synthesis
  • make structured JSON verdicts the machine source of truth while preserving reviewer reports in pr_gate_result_v3
  • align all reviewer prompts, runtime verification, fallback generation, and documentation entry points
  • consolidate shared PR-gate fixtures and update affected-suite mappings and test documentation

Why

Reviewer completion was coupled to Markdown heading formatting, so duplicated or omitted prose could turn a substantively complete review into a protocol failure. Reviewer outputs also lacked one deterministic contract for coverage, evidence, findings, and aggregate verdict parity.

Impact

Selected reviewers now produce machine-verifiable, scope-bound results. Protocol defects fail closed as INCOMPLETE, while actual reviewer verdicts remain distinct and deterministic across sequential and parallel execution.

Validation

  • affected-test PR gate: GO before the final comment-only Behavior/Steps annotation; the owner explicitly accepted retaining that GO without a gate rerun
  • bash tests/bin/run-all-tests.sh: PASS — 97 passed, 0 failed, 0 skipped
  • bash tests/bin/run-tests.sh --verify-full .pm-dispatch/test-results/latest-full.json: verified authoritative full PASS for the committed tree
  • git diff --check: PASS

@screenleon
screenleon marked this pull request as ready for review July 30, 2026 01:59
@screenleon
screenleon merged commit 8c3778b into main Jul 30, 2026
57 checks passed
@screenleon
screenleon deleted the feat/CC-519 branch July 30, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant