fix(ui): align macos accelerators with platform expectations - #765
fix(ui): align macos accelerators with platform expectations#765fenbyte wants to merge 1 commit into
Conversation
|
thanks a lot ٩(˘◡˘)۶ |
| }); | ||
| add_window_action(shell, "mute", &["<Control>m"], { | ||
| #[cfg(target_os = "macos")] | ||
| let mute_accels = &["<Meta>m"][..]; |
There was a problem hiding this comment.
Isn't this for minimizing windows?
Put the Music window in the Dock | Command-M
There was a problem hiding this comment.
iina uses cmd+/, not sure about that one though...
There was a problem hiding this comment.
I think it is fine to drop our keybinds for these, I just used initial letters without much thought but there is no specific reason to keep them
There was a problem hiding this comment.
ctrl +/- is used for volume currently though
There was a problem hiding this comment.
what about m? that seems pretty easy to figure out, and spotify uses that
| }); | ||
| add_window_action(shell, "seek-forward", &["<Control>Right"], { | ||
| #[cfg(target_os = "macos")] | ||
| let seek_forward_accels = &["Right", "<Shift><Meta>Right"][..]; |
There was a problem hiding this comment.
did you know that you can navigate between rows and grids with arrow keys :P
so we would want to avoid bare left/right for seekback
There was a problem hiding this comment.
Actually, it makes more sense to reverse these; navigation can take ctrl keybinding since that is more niche
| shell.chrome.window.add_action(&fullscreen); | ||
|
|
||
| add_window_action(shell, "play-pause", &["<Control>space"], { | ||
| add_window_action(shell, "play-pause", &["space"], { |
There was a problem hiding this comment.
bare Space already works, so this would duplicate that
or does it not work on MacOS?
There was a problem hiding this comment.
oh, yeah this works already, oops
|
I forgot to submit the review LOL |
|
LOL all good |
|
what should we do about this, should I handle the navigation keybinds part? I still kind of want to entrust exact Mac keybinds to you lol |
|
i think seeking should be left and right alone and navigation would require command to be held. maybe volume should be up and down alone too since i don't know of a single mac app that uses cmd+= and cmd+-. this behaviour would match most media and music players i think. obviously if the cursor is in a text ox this shouldn't happen anymore but i'm sure gtk handles that or something |
|
actually itunes/apple music lets you scroll up and down the list with up and down keys but next/previous track with left and right... honestly i think this one is up to your preference, but i'm gonna refresh my memory on some apps real quick |
|
ok i think i like the way spotify does things. arrow keys are for navigation and scrolling, cmd+left/right is for previous/next track, shift+cmd+left/right is for seeking, and cmd+up/down are for volume |
|
that sounds fine, especially for volume |
2 participants
my first time writing any rust, be nice!
fixes #764