Skip to content

Fix #36 Chunks forced by other mods or /forceload are removed every tick #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scriptcoded merged 2 commits into from
Apr 5, 2026
+10 −2
Merged

Fix #36 Chunks forced by other mods or /forceload are removed every tick #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a639a9a
chore: add TicketType CUSTOM_TICKETTYPE_FORCED
Craemon Apr 4, 2026
1151b62
chore: exchange setChunkForced with adding Custom Chunk Ticket
Craemon Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/main/java/io/nihlen/scriptschunkloaders/ChunkLoaderManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import it.unimi.dsi.fastutil.longs.LongSet;
import net.fabricmc.fabric.api.event.lifecycle.v1.ServerTickEvents;
import net.minecraft.server.level.ChunkMap;
import net.minecraft.server.level.Ticket;
import net.minecraft.world.entity.Entity;
import net.minecraft.resources.ResourceKey;
import net.minecraft.server.MinecraftServer;
Expand Down Expand Up @@ -104,15 +106,16 @@ private void updateChunkLoaders(ServerLevel world) {

if (!loadedChunks.contains(longPos)) {
// Load chunk
world.setChunkForced(chunkPos.x(), chunkPos.z(), true);
var ticket = new Ticket(ScriptsChunkLoadersMod.CUSTOM_TICKETTYPE_FORCED, ChunkMap.FORCED_TICKET_LEVEL);
world.getChunkSource().addTicket(ticket, chunkPos);
}
});

loadedChunks.forEach(longPos -> {
var chunkPos = ChunkPos.unpack(longPos);
if (!currentChunks.contains(chunkPos)) {
// Unload chunk
world.setChunkForced(chunkPos.x(), chunkPos.z(), false);
world.getChunkSource().removeTicketWithRadius(ScriptsChunkLoadersMod.CUSTOM_TICKETTYPE_FORCED, chunkPos, 2);
}
});
}
Expand Down
5 changes: 5 additions & 0 deletions src/main/java/io/nihlen/scriptschunkloaders/ScriptsChunkLoadersMod.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

import net.fabricmc.api.ModInitializer;
import net.fabricmc.fabric.api.event.lifecycle.v1.ServerLifecycleEvents;
import net.minecraft.core.Registry;
import net.minecraft.core.registries.BuiltInRegistries;
import net.minecraft.server.level.TicketType;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand All @@ -13,6 +16,8 @@ public class ScriptsChunkLoadersMod implements ModInitializer {
// That way, it's clear which mod wrote info, warnings, and errors.
public static final Logger LOGGER = LoggerFactory.getLogger(MODID);
public static final ChunkLoaderManager CHUNK_LOADER_MANAGER = new ChunkLoaderManager();
// Add Custom TicketType, Flags are set to mimic FORCED.
public static final TicketType CUSTOM_TICKETTYPE_FORCED = Registry.register(BuiltInRegistries.TICKET_TYPE, ScriptsChunkLoadersMod.MODID, new TicketType(TicketType.NO_TIMEOUT, TicketType.FLAG_PERSIST | TicketType.FLAG_LOADING | TicketType.FLAG_SIMULATION | TicketType.FLAG_KEEP_DIMENSION_ACTIVE));

@Override
public void onInitialize() {
Expand Down
Loading