optimize preflight executor #1225
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero78119
force-pushed
the
feat/optimize_executor
branch
from
0cdffd5 to
796c161
Compare
hero78119
changed the base branch from
feat/dispatch_and_alloc
to
feat/load_store_w
hero78119
force-pushed
the
feat/optimize_executor
branch
from
796c161 to
3a3e7c3
Compare
hero78119
changed the base branch from
feat/load_store_w
to
feat/dispatch_and_alloc
hero78119
force-pushed
the
feat/optimize_executor
branch
6 times, most recently
from
43e57cb to
21fd725
Compare
empty && preflight executer more debug log preflight conditionally update next_access handle final cycle gracefully set shard boundary initial value
hero78119
force-pushed
the
feat/optimize_executor
branch
from
21fd725 to
de244ac
Compare
hero78119
force-pushed
the
feat/optimize_executor
branch
from
de244ac to
a17fdbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design rationales
Refactor shard cycle logic into pre-flight tracer in low overhead way. With that, in preflight tracer we only update
next_accesswith cross-shard memory access. This optimization bring much gain on preflight executor performancebenchmark
test on
23817600