feat: class-based shuffler#108
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
==========================================
+ Coverage 90.22% 92.18% +1.95%
==========================================
Files 6 6
Lines 583 614 +31
==========================================
+ Hits 526 566 +40
+ Misses 57 48 -9
🚀 New features to boost your workflow:
|
|
@felix0097 I am requesting your review but if you don't want to comb through the code changes that's fine. Please have a look at the docs/API changes and just make sure you're comfortable with them. |
felix0097
left a comment
There was a problem hiding this comment.
Looks good to me now!
To keep track this were the items we discussed:
- Only support
use_collectionfor now that the user isn't able to do weird stuff - Check if removing
sample_rowsfunction hurts performance for dense data -> if yes, potentially add it back in - By default, yield
varas well
#25 but let's wait for #101 to reimplement this much more simply
With one collection? yes that's in the implemention |
Closes #94 and closes #66