Use Rarr::write_zarr_group to write zarr store/group - #490
Open
Artur-man wants to merge 13 commits into
Open
Conversation
|
Bencher Report| Project | anndataR |
| Branch | write_group |
| Testbed | ubuntu-latest |
⚠️ WARNING: Truncated view!The full continuous benchmarking report exceeds the maximum length allowed on this platform.
🚨 3 Alerts
🐰 View full continuous benchmarking report in Bencher
Member
|
Thanks! Could you set the minimum version of rarr in the description to 2.1.27? |
Contributor
Author
|
Everything looks good but since > 2.1.26 is not loaded we fail some CIs (Rarr devel is >= 2.1.29 now). |
6 tasks
Contributor
Author
|
Tests look ok, but |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: Huber-group-EMBL/Rarr#208
Description
Replacing temporary zarr utilities
create_zarr(_group)with new built-inwrite_zarr_groupin Rarr 2.1.27. We can also keep this PR as it is until #455 is merged, might make the merge of this PR easier sincewrite_zarr_groupshould always be set tozarr_version=2Lwithout #455.UPDATE: Since #455 is merged,
formatis now passed tozarr_versionforRarr::write_zarr_group.Checklist
Before review
Before merge
NEWS