Preserve GCM provider errors and skip terminal retries - #45
Open
thomasgregg wants to merge 1 commit into
Open
thomasgregg wants to merge 1 commit into
thomasgregg wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FcmRegistrationErrordetails for provider-side registration failures.PHONE_REGISTRATION_ERRORas non-retryable for the current identity.Why
gcm_register()currently repeatsPHONE_REGISTRATION_ERRORfour times with the same Android ID, security token, and GCM app ID. Because none of the identity inputs change, these requests cannot recover from a deterministic identity rejection. The provider code is then collapsed into a generic registration failure, so callers cannot choose an appropriate recovery policy.FcmRegistrationErrorremains aRuntimeError, while adding stablestage,code, andretryableattributes. This lets downstream callers use long backoff for terminal identity errors without parsing log strings. The exception message contains only the stage and provider code, not credentials.This improves the behavior and diagnostics discussed in #32; it intentionally does not claim to fix the undocumented provider-side reason for the rejection.
Tests
PHONE_REGISTRATION_ERRORproduces one request, no sleep, and a typed non-retryable error.SERVICE_NOT_AVAILABLEstill makes four attempts, sleeps only between attempts, and retains the typed provider details.15 passed.git diff --checkpass.