Skip to content

Schema upload path #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
steiler wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Schema upload path #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,9 @@ func (c *Config) validateSetDefaults() error {
return fmt.Errorf("unknown schema store type %q", c.SchemaStore.Type)
}
}
if c.SchemaStore != nil && c.SchemaStore.UploadPath == "" {
c.SchemaStore.UploadPath = "/schemas"
}
if c.SchemaStore == nil && (c.GRPCServer.SchemaServer == nil || !c.GRPCServer.SchemaServer.Enabled) {
return errors.New("schema-server RPCs cannot be exposed if the schema server is not enabled")
}
Expand Down
4 changes: 2 additions & 2 deletions pkg/server/schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ func (s *Server) createLocalSchemaStore(ctx context.Context) {
var store schemaStore.Store
switch s.config.SchemaStore.Type {
case schemaConfig.StoreTypeMemory:
store = schemaMemoryStore.New()
store = schemaMemoryStore.New(s.config.SchemaStore.UploadPath)
case schemaConfig.StoreTypePersistent:
var err error
store, err = schemaPersistentStore.New(ctx, s.config.SchemaStore.Path, s.config.SchemaStore.Cache)
store, err = schemaPersistentStore.New(ctx, s.config.SchemaStore.UploadPath, s.config.SchemaStore.Path, s.config.SchemaStore.Cache)
if err != nil {
log.Errorf("failed to create a persistent schema store: %v", err)
os.Exit(1)
Expand Down
Loading