Skip to content

improve sync logging#418

Open
steiler wants to merge 1 commit intomainfrom
synclogging
Open

improve sync logging#418
steiler wants to merge 1 commit intomainfrom
synclogging

Conversation

@steiler
Copy link
Copy Markdown
Collaborator

@steiler steiler commented Apr 27, 2026

we where logging errors for more or less expected situations

we where logging errors for more or less expected situations
@steiler steiler requested a review from a team as a code owner April 27, 2026 09:12
@steiler steiler requested a review from alexandernorth April 27, 2026 09:12
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/datastore/sync.go 40.00% 3 Missing ⚠️
pkg/tree/ops/navigatesdcpbpath.go 80.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@severindellsperger severindellsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If we have more errors in the future, we could consider moving them to a dedicated error file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants