feat: Generalised Minkowski Metric (L_p norm)#291
Open
cbueth wants to merge 22 commits intosdd:v5.x.xfrom
Open
feat: Generalised Minkowski Metric (L_p norm)#291cbueth wants to merge 22 commits intosdd:v5.x.xfrom
cbueth wants to merge 22 commits intosdd:v5.x.xfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v5.x.x #291 +/- ##
==========================================
+ Coverage 95.02% 95.05% +0.02%
==========================================
Files 54 54
Lines 6252 6286 +34
Branches 6252 6286 +34
==========================================
+ Hits 5941 5975 +34
Misses 287 287
Partials 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cbueth
force-pushed
the
feature/minkowski
branch
from
d7bebf0 to
8ce492a
Compare
…lidean distance metrics
- deprecate `rd_update` with `D::accumulate` for consistent sum-based and max-based metrics - conditional logic for SIMD (L1/L2) and general L∞ - differentiate distance accumulation behaviour
- integration `nearest_n` tests (Chebyshev, Manhattan, SquaredEuclidean).
- improve `DistanceMetric` doc - add Gaussian scenario to tests
… trait - improve test coverage
- `A::dist` - `saturating_mul`
…metrics - clarify usage scenarios
…h parameterised power
cbueth
force-pushed
the
feature/minkowski
branch
from
8ce492a to
ece9275
Compare
Author
|
I have merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a reopen for #287 after integrating the feedback from #286 . See the description in the initial PR. All tests still pass locally.
Closes #287