Strings to enums#25

Open

tkanakamalla wants to merge 19 commits into

sdroege:mainfrom

tkanakamalla:strings_to_enums

tkanakamalla commented Jun 24, 2025 •

edited

Loading

Collaborator

Fixes #1

tkanakamalla marked this pull request as draft

June 24, 2025 15:19

sdroege reviewed

View reviewed changes

sdroege left a comment

Owner

Otherwise looks good to me

src/lib.rs Outdated

src/lib.rs Outdated

src/lib.rs Outdated

src/lib.rs Outdated

src/lib.rs Outdated

src/lib.rs Outdated

src/lib.rs Outdated

tkanakamalla force-pushed the strings_to_enums branch 2 times, most recently from d9257ff to 5286f1a Compare

July 7, 2025 12:17

sdroege reviewed

View reviewed changes

src/lib.rs Outdated

sdroege reviewed

View reviewed changes

src/lib.rs Outdated

tkanakamalla force-pushed the strings_to_enums branch from 5286f1a to 5d0d703 Compare

July 8, 2025 07:29

sdroege reviewed

View reviewed changes

src/lib.rs Outdated

sdroege reviewed

View reviewed changes

src/lib.rs Outdated

sdroege reviewed

View reviewed changes

src/lib.rs Outdated

sdroege reviewed

View reviewed changes

src/lib.rs Outdated

sdroege reviewed

View reviewed changes

src/lib.rs Outdated

sdroege commented Jul 8, 2025

Owner

clippy should be clean if you rebase on top of latest main

tkanakamalla force-pushed the strings_to_enums branch 2 times, most recently from 703493f to a9c14b7 Compare

July 8, 2025 12:06

tkanakamalla force-pushed the strings_to_enums branch 3 times, most recently from 02ea209 to b7942a5 Compare

August 1, 2025 15:03

sdroege reviewed

View reviewed changes

src/lib.rs Outdated

+                  /// Payload type, a numerical value between 0 and 127
+                  pub pt: u8,
+                  /// Name of the encoding
+                  // TODO: is it useful to have an enum for all known encoding?

sdroege Aug 5, 2025

Owner

Potentially useful, just like for the registered payload types. But in this struct here, a string / u8 is the correct thing. You could have functions on the struct that try to handle pt / encoding with those enums though

sdroege Aug 5, 2025

Owner

https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/blob/44a632811e6718909409b5c229508072a1447e62/net/rtsp/src/rtspsrc/sdp.rs#L215 basically having guess_rtpmap_from_pt() and guess_rtpmap_from_encoding_name() here in some form seems useful.

@nirbheek Do you remember why your code allows rtpmap without clock-rate? The SDP RFC does not allow that

nirbheek Aug 5, 2025

There are payload types for which clock-rate is static, and tools like ffmpeg won't add the clock-rate in those cases. For example pt=10/11 (L16 2ch/1ch), see table in https://en.wikipedia.org/wiki/RTP_payload_formats#Audio_and_video_payload_types.

sdroege Aug 5, 2025

Owner

Thanks. ffmpeg is wrong to not add it of course, specifying the clock rate in the SDP is not optional.

sdroege reviewed

View reviewed changes

src/lib.rs Outdated

sdroege reviewed

View reviewed changes

src/lib.rs Outdated

sdroege reviewed

View reviewed changes

src/lib.rs Outdated

sdroege reviewed

View reviewed changes

src/lib.rs Outdated

sdroege reviewed

View reviewed changes

src/lib.rs Outdated

sdroege reviewed

View reviewed changes

src/lib.rs Outdated

sdroege reviewed

View reviewed changes

src/lib.rs Outdated

sdroege reviewed

View reviewed changes

src/lib.rs Outdated

sdroege reviewed

View reviewed changes

src/lib.rs Outdated

sdroege reviewed

View reviewed changes

src/lib.rs Outdated

sdroege reviewed

View reviewed changes

src/lib.rs Outdated

sdroege reviewed

View reviewed changes

src/enums.rs Outdated

sdroege reviewed

View reviewed changes

src/attributes.rs Outdated

src/enums.rs

src/enums.rs Outdated

src/enums.rs Outdated

src/enums.rs Outdated

src/enums.rs Outdated

src/enums.rs Outdated

sdroege reviewed

View reviewed changes

src/attributes.rs Outdated

src/attributes.rs

src/attributes.rs Outdated

src/attributes.rs Outdated

src/attributes.rs Outdated

tkanakamalla force-pushed the strings_to_enums branch from cac7add to 149ece4 Compare

June 10, 2026 18:01

tkanakamalla requested review from fengalin and sdroege

June 10, 2026 18:09

tkanakamalla force-pushed the strings_to_enums branch from 149ece4 to 56ef12c Compare

June 11, 2026 12:57

fengalin reviewed

View reviewed changes

src/attributes.rs Outdated

src/lib.rs Outdated

src/attributes.rs Outdated

src/attributes.rs

src/attributes.rs Outdated

src/enums.rs

src/enums.rs

src/enums.rs Outdated

src/enums.rs Outdated

src/lib.rs Outdated

tkanakamalla added 2 commits

June 12, 2026 17:09


          Add new enums to convert from strings

ca4ad2e

and write new methods to access the parsed SDP members as enums


          add new attribute error

0020f13

tkanakamalla force-pushed the strings_to_enums branch from 56ef12c to 5650189 Compare

June 12, 2026 13:05

tkanakamalla and others added 16 commits

June 12, 2026 21:57


          add new struct for RtpMap

347b309


          add fmtp attribute struct

871179e


          add rtcp struct

9f6cef0


          add a new trait TypedAttributes for attributes

e8468d5


          update doc about typedattributes

0b0726f


          merge all impls of Media and Session

ca12bdc


          add struct for rtcp-fb attribute

87a0d53


          add struct for extmap and enum for direction attributes

05ce7df


          add struct for fingerprint attribute

7aa8b98


          add struct for group attribute

3ccaa6d


          add enum for setup attribute

f576962


          add structs for ssrc and ssrc-group attributes

7088f1b


          add struct for crypto attribute and SRTP parameters

06b8c20


          add candidate attribute

855039c


          refactor lib.rs and improve Attribute errors

d8bf42d

- move the enums and attribute structs to separate files
- define different types of attributes errors and expose them as enum
  variants so they can be type matched by the application


          avoid unwanted heap allocations wherever possible

ce8fde6

- improve Display impl everywhere to use write!() intead of reallocation
- use .eq_ignore_ascii_case to compare strings

tkanakamalla force-pushed the strings_to_enums branch from 5650189 to 7f532fc Compare

June 12, 2026 17:51


          typo and documentation fixes

2a3f190

tkanakamalla force-pushed the strings_to_enums branch from 7f532fc to 2a3f190 Compare

June 12, 2026 17:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet