Skip to content

domains: support MCS and non-MCS, use units - #38

Merged
midnightveil merged 1 commit into
masterfrom
julia/domain-mcs-units
Jul 20, 2026
Merged

domains: support MCS and non-MCS, use units#38
midnightveil merged 1 commit into
masterfrom
julia/domain-mcs-units

Conversation

@midnightveil

@midnightveil midnightveil commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

This adds demonstrate of units in the CAmkES domain schedule example. It also adds a new domains-mcs file that works with 'us' only for MCS.

Test with: seL4/capdl#95, seL4/camkes-tool#178

@midnightveil

Copy link
Copy Markdown
Contributor Author

Well that CI is also broken.

@midnightveil
midnightveil requested a review from lsf37 July 15, 2026 06:46
Comment thread apps/domains/domains.camkes

@lsf37 lsf37 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating that! I'll have a look at the CI failure later.

This adds demonstrate of units in the CAmkES domain
schedule example. It also adds a new domains-mcs file
that works with 'us' only for MCS.

Signed-off-by: Julia Vassiliki <julia.vassiliki@unsw.edu.au>
@midnightveil
midnightveil force-pushed the julia/domain-mcs-units branch from 6cd67b1 to b53dfec Compare July 16, 2026 00:34
@midnightveil

Copy link
Copy Markdown
Contributor Author

(Force push to fix style CI)

@midnightveil

Copy link
Copy Markdown
Contributor Author

There's probably some config in ci-actions somewhere to do an MCS build of the domains example, right?

@lsf37

lsf37 commented Jul 16, 2026

Copy link
Copy Markdown
Member

There's probably some config in ci-actions somewhere to do an MCS build of the domains example, right?

I need to look into that, I'm not sure there are any other tested MCS examples for CAmkES currently. I did figure out the Camkes VM Examples error: it triggers because I added set -e for the repo checkout script and the camkes repo doesn't occur in the VM examples manifest (only camkes-tools). Which means these tests could never break from changes in this repo.

The additional "Test with" has fixed the other tests and confirms that the non-MCS version at least is working. I'll double-check the MCS version.

@midnightveil
midnightveil merged commit d8cc099 into master Jul 20, 2026
32 of 44 checks passed
@midnightveil
midnightveil deleted the julia/domain-mcs-units branch July 20, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants