Skip to content

python-capdl-tool: remove future package - #102

Merged
lsf37 merged 1 commit into
masterfrom
lsf37/python3
Jul 30, 2026
Merged

python-capdl-tool: remove future package#102
lsf37 merged 1 commit into
masterfrom
lsf37/python3

Conversation

@lsf37

@lsf37 lsf37 commented Jul 30, 2026

Copy link
Copy Markdown
Member

Only needed for python2/3 compatibility which is now obsolete.

There is still the compatibility package six left, but I need to read up on what all this metaclass stuff is that the current code is doing with it.

Only needed for python2/3 compatibility which is now obsolete.

Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
@lsf37
lsf37 requested a review from midnightveil July 30, 2026 07:44

@midnightveil midnightveil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The six.with_metaclass(ABCMeta, object) is doing two things: inheriting classes from object explicitly (something that was not the default in Py2) and setting metaclass to ABCMeta to make instantiating Object not possible without all the @abstractmethod being implemented. You should be able to replace them all with https://docs.python.org/3/library/abc.html#abc.ABC. (Actually not sure why ContainerObject needs it).

@lsf37

lsf37 commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

Thanks for that, I was fearing I had to read a lot more to understand this :-)

@lsf37
lsf37 merged commit 75d8f8a into master Jul 30, 2026
10 of 11 checks passed
@lsf37
lsf37 deleted the lsf37/python3 branch July 30, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants