Let deployment jobs finish when new commits are pushed - #1036
Merged
Conversation
Don't cancel deployment jobs that have started when a new commit is pushed. Instead let it finish so that the job in the new commit can benefit from the images built in the first one. Make the concurrency group ID that controls this more robust. The previous strategy.job-index was dependent on the order GitHub expanded the matrix in. Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
lsf37
force-pushed
the
deploy-concurrency
branch
from
July 22, 2026 08:25
3d2c764 to
199f765
Compare
Member
Author
|
(Should be merged after the release has finished) |
Xaphiosis
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't cancel deployment jobs that have started when a new commit is pushed. Instead let it finish so that the job in the new commit can benefit from the images built in the first one. This would have sped up the seL4 release cycle by at least one full proof run today (maybe two).
Make the concurrency group ID that controls this more robust in both deployment and PR jobs. The previous strategy.job-index was dependent on the order GitHub expanded the matrix in.