Skip to content

domains: support units for schedule duration - #360

Merged
nspin merged 3 commits into
seL4:mainfrom
au-ts:julia/domsched-units
Jul 20, 2026
Merged

domains: support units for schedule duration#360
nspin merged 3 commits into
seL4:mainfrom
au-ts:julia/domsched-units

Conversation

@midnightveil

Copy link
Copy Markdown
Contributor

This is an implementation of the equivalent change to the C/Haskell capDL initialiser with the commit name
'Support domain schedule units (us & ticks)'.
For justification of the algorithm within, its correctness, and discussion of why we want it, please see that PR.

seL4/capdl#95

Note: I have not tested the non-MCS Rust implementation, but I will be testing the MCS one with Microkit. I can't seem to compile rust-sel4 by itself (the make examples fails to fetch seL4 commits properly for reasons I don't understand).

Opening this for review early.

@midnightveil
midnightveil requested a review from nspin as a code owner July 16, 2026 03:50
@midnightveil

midnightveil commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

I don't understand why the build fails, it works locally. Nevermind, for some reason seL4_Time was only defined for MCS, even though seL4 exposes it for both MCS and non-MCS.

@midnightveil
midnightveil force-pushed the julia/domsched-units branch from 41e1383 to 64a3d6f Compare July 16, 2026 04:49
Comment thread crates/sel4-capdl-initializer/types/src/spec.rs Outdated
Comment thread crates/sel4-capdl-initializer/src/initialize.rs Outdated
Comment thread crates/sel4-capdl-initializer/src/error.rs Outdated
@midnightveil
midnightveil force-pushed the julia/domsched-units branch 3 times, most recently from d11f082 to de60f92 Compare July 17, 2026 02:18
@midnightveil
midnightveil force-pushed the julia/domsched-units branch 3 times, most recently from 7c54438 to 960b731 Compare July 17, 2026 05:50
@midnightveil

Copy link
Copy Markdown
Contributor Author

This failure is because it needs an seL4 version update, as it was not exporting TIMER_FREQUENCY when it should have been. seL4/seL4#1708

@midnightveil
midnightveil force-pushed the julia/domsched-units branch from 960b731 to 1a47524 Compare July 19, 2026 00:20
@midnightveil

midnightveil commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Rebased on #362. that's been merged

@midnightveil
midnightveil force-pushed the julia/domsched-units branch 4 times, most recently from b2acb35 to eb57f73 Compare July 20, 2026 03:50
midnightveil added a commit to seL4/capdl that referenced this pull request Jul 20, 2026
This matches the corresponding [Rust PR](
seL4/rust-sel4#360).

Signed-off-by: Julia Vassiliki <julia.vassiliki@unsw.edu.au>
@midnightveil
midnightveil force-pushed the julia/domsched-units branch from eb57f73 to a61cbf2 Compare July 20, 2026 04:26
Comment thread crates/sel4/src/lib.rs Outdated
Comment thread crates/sel4/src/lib.rs Outdated
@midnightveil
midnightveil force-pushed the julia/domsched-units branch 2 times, most recently from d82cd69 to 73da7f1 Compare July 20, 2026 06:51
Upstream only prints "starting domain schedule" if both
the set_start and schedule conditions are true, whilst
this one prints it if there is a list of schedules.

Also refactor to put the early-exits first.

Signed-off-by: Julia Vassiliki <julia.vassiliki@unsw.edu.au>
This is used by the domain scheduler API.

Signed-off-by: Julia Vassiliki <julia.vassiliki@unsw.edu.au>
This is an implementation of the equivalent change to the
C/Haskell capDL initialiser with the commit name
'Support domain schedule units (us & ticks)'.
For justification of the algorithm within, its correctness,
and discussion of why we want it, please see that PR.

Signed-off-by: Julia Vassiliki <julia.vassiliki@unsw.edu.au>
@midnightveil
midnightveil force-pushed the julia/domsched-units branch from 73da7f1 to 9f5f8ec Compare July 20, 2026 06:51
midnightveil added a commit to seL4/capdl that referenced this pull request Jul 20, 2026
This matches the corresponding [Rust PR](
seL4/rust-sel4#360).

Signed-off-by: Julia Vassiliki <julia.vassiliki@unsw.edu.au>
midnightveil added a commit to seL4/capdl that referenced this pull request Jul 20, 2026
This matches the corresponding [Rust PR](
seL4/rust-sel4#360).

Signed-off-by: Julia Vassiliki <julia.vassiliki@unsw.edu.au>
@nspin
nspin merged commit 4edc3cd into seL4:main Jul 20, 2026
14 checks passed
@midnightveil
midnightveil deleted the julia/domsched-units branch July 20, 2026 07:44
midnightveil added a commit to seL4/capdl that referenced this pull request Jul 20, 2026
This matches the corresponding [Rust PR](
seL4/rust-sel4#360).

Signed-off-by: Julia Vassiliki <julia.vassiliki@unsw.edu.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants