Fix log_event alight by avoiding unassigned record field reference#5
Open
sean2249 wants to merge 1 commit into
Open
Fix log_event alight by avoiding unassigned record field reference#5sean2249 wants to merge 1 commit into
sean2249 wants to merge 1 commit into
Conversation
The previous fix gated v_pred field access on `v_src is null`, but PL/pgSQL still resolves v_pred's tuple structure when compiling the CASE expression, raising "record v_pred is not assigned yet" on alight events where v_pred is never assigned. Move the prediction JSON build inside the board branch where v_pred is guaranteed assigned, and return a pre-built jsonb variable from the outer return. https://claude.ai/code/session_01P38Yh6XMhrQupsB2xSS8no
There was a problem hiding this comment.
Pull request overview
Updates the commute.log_event PL/pgSQL function to avoid the runtime error "record v_pred is not assigned yet" when logging alight events by ensuring v_pred fields are only referenced in code paths where v_pred is guaranteed to be assigned.
Changes:
- Moves prediction JSON construction into the
board-only branch wherev_predhas been populated. - Introduces a
v_predictionjsonb variable and returns it directly from the outerjsonb_build_object.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous fix gated v_pred field access on
v_src is null, butPL/pgSQL still resolves v_pred's tuple structure when compiling the
CASE expression, raising "record v_pred is not assigned yet" on
alight events where v_pred is never assigned. Move the prediction
JSON build inside the board branch where v_pred is guaranteed
assigned, and return a pre-built jsonb variable from the outer
return.
https://claude.ai/code/session_01P38Yh6XMhrQupsB2xSS8no