Refactor OPENASTROVIZD_SOCKET readiness parsing to explicit URI schemes#78
Merged
seanwevans merged 2 commits intomainfrom Apr 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
target.contains(':'), which was brittle and misclassified Windows paths and other inputs.Description
ReadinessTargetenum and aparse_readiness_targetfunction that acceptstcp://,unix://, andfile://URIs.tcp://addresses usingToSocketAddrsand normalize filesystem URIs withpath_from_uri(including Windows drive-letter handling), and expose readiness checks viareadiness_target_readyused fromwait_for_readiness.socket_readyhelper test-only and add unit tests covering scheme-required behavior and parser acceptance/rejection cases.README.md,daemon/README.md, anddaemon/openastrovizd/README.mdto document the acceptedOPENASTROVIZD_SOCKETformats with examples.Testing
cargo test -p openastrovizd parse_readiness_target, which executed parser tests and passed (2 passed).cargo test -p openastrovizd socket_ready_requires_scheme, which passed (1 passed).cargo fmt --allbut formatting failed in this environment becauserustfmtis not installed for the active toolchain.Codex Task