Skip to content

🧪 [testing improvement] Add error path tests for WebSocketHelper and fix CI type errors#14

Merged
sebamar88 merged 3 commits into
mainfrom
improve-websocket-tests-10745326257403051512
Mar 20, 2026
Merged

🧪 [testing improvement] Add error path tests for WebSocketHelper and fix CI type errors#14
sebamar88 merged 3 commits into
mainfrom
improve-websocket-tests-10745326257403051512

Conversation

@sebamar88
Copy link
Copy Markdown
Owner

🎯 What: Added tests for missing error paths in WebSocketHelper and fixed CI type errors in CLI and CryptoUtils.
📊 Coverage:

  • Registered multiple handlers and verified that if one throws an error, subsequent handlers are still executed.
  • Threw a non-Error value (a string) from a handler and verified that it is correctly wrapped into an Error object by notifyError.
  • Fixed type mismatch in src/cli/index.ts by ensuring url is passed as a non-nullable string.
  • Fixed type mismatch in src/utils/helpers/CryptoUtils.ts by casting Uint8Array to BufferSource for crypto.subtle.importKey.
    ✨ Result: Improved reliability, coverage, and build stability.

PR created automatically by Jules for task 10745326257403051512 started by @sebamar88

google-labs-jules Bot and others added 2 commits March 18, 2026 12:31
Co-authored-by: sebamar88 <4359231+sebamar88@users.noreply.github.com>
Co-authored-by: sebamar88 <4359231+sebamar88@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@sonarqubecloud
Copy link
Copy Markdown

@sebamar88 sebamar88 merged commit 4c604b0 into main Mar 20, 2026
6 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant