Skip to content

Feature/security scan#195

Merged
AsgerT10 merged 18 commits into
developfrom
feature/security-scan
May 7, 2026
Merged

Feature/security scan#195
AsgerT10 merged 18 commits into
developfrom
feature/security-scan

Conversation

@AsgerT10
Copy link
Copy Markdown
Collaborator

add semgrep as security tool

@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 30, 2026

Not up to standards ⛔

🔴 Issues 1 high

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
Security 1 high

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Comment thread Makefile Outdated
Comment thread Makefile Outdated
@sebsthiel
Copy link
Copy Markdown
Owner

Looks good to me

Comment thread .github/workflows/develop-pr.yml Outdated
- name: Build
run: go build ./...

- name: Build Docker images
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are again building the images multiple times.

Maybe remove the build step here and move the trivy scans to the "merged-tests.yml" file instead?
That way we can reuse the build images

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 3, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

Copy link
Copy Markdown
Owner

@sebsthiel sebsthiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it seems good to me now 👍

@AsgerT10 AsgerT10 merged commit 6617961 into develop May 7, 2026
2 of 4 checks passed
@mekererenate-web mekererenate-web deleted the feature/security-scan branch May 14, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants