Skip to content

fix: href-clickable#208

Merged
rainer-exxcellent merged 3 commits intomainfrom
fix-href-clickable
Nov 17, 2025
Merged

fix: href-clickable#208
rainer-exxcellent merged 3 commits intomainfrom
fix-href-clickable

Conversation

@mfd2007
Copy link
Copy Markdown
Contributor

@mfd2007 mfd2007 commented Sep 8, 2025

PR migrates changes in the template process from Secvisogram (see secvisogram/secvisogram#511)

This PR isolates the changes to the mustache templates from #197 from other changes and replaces #197

@mfd2007 mfd2007 mentioned this pull request Sep 8, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 8, 2025

Test Results

304 tests   304 ✅  34s ⏱️
 23 suites    0 💤
 23 files      0 ❌

Results for commit 536af8f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 8, 2025

Overall Project 90.05% 🍏

There is no coverage information present for the Files changed

@rainer-exxcellent rainer-exxcellent self-assigned this Sep 23, 2025
@rainer-exxcellent rainer-exxcellent self-requested a review October 1, 2025 12:54
Copy link
Copy Markdown
Contributor

@rainer-exxcellent rainer-exxcellent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, the URL is repeated in round brackets. Is this intentional?

Image

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 2, 2025

Overall Project 90.05% 🍏

There is no coverage information present for the Files changed

@mfd2007
Copy link
Copy Markdown
Contributor Author

mfd2007 commented Oct 2, 2025

If there is still a difference to the preview in Secvisogram, please fix it.

@rainer-exxcellent
Copy link
Copy Markdown
Contributor

If there is still a difference to the preview in Secvisogram, please fix it.

The round brackets are inserted via CSS selector:

What was the initial intention of this Selector? It is still necessary?

@github-actions
Copy link
Copy Markdown
Contributor

Overall Project 90.05% 🍏

There is no coverage information present for the Files changed

Copy link
Copy Markdown
Contributor

@rainer-exxcellent rainer-exxcellent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rainer-exxcellent rainer-exxcellent merged commit 4b61f5f into main Nov 17, 2025
3 checks passed
@rainer-exxcellent rainer-exxcellent deleted the fix-href-clickable branch November 17, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants