Conversation
Collaborator
|
Thank you for opening the PR. One thing that has always been bugging me is how the data that describes the Shimmer hardware, such as the data types for the channels, has always just been lying around in the code base without being properly abstracted away. I am currently working on this in #31 . With it, there are still going to be dictionaries in the code base, but there's not going to be any direct interaction with them anymore. Everything that's relevant will be in the |
Contributor
Author
Contributor
Author
|
closing this as a new approach has been developed via #36 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.