Update shimmer3r.py - #39
Merged
Merged
Conversation
pressure and temp sensor format update
lumagi
added a commit
that referenced
this pull request
Feb 20, 2026
* Current working state of Shimmer HardwareRevision * Implement dedicated HardwareRevision class for Shimmer3 * Move revision module around and add license notices * Implement test cases for Shimmer3 revision * Add missing future annotations import * Remove unused method in HardwareRevision * Move ESensorGroup unique test to separate group * Add more tests for HW Revision 3 * Add HardwareRevision to Bluetooth command constructors, reformat docstrings * Update Bluetooth Command Tests * Fix some of the tests * Move HardwareVersion into separate module * Link the HardwareRevision to the HardwareVersion enum * Update the Bluetooth API to use the new revision class * Update revision handling in ShimmerBluetooth * Update the BluetoothRequestHandler tests * Fix HardwareVersion initialization * Update Bluetooth tests * Rewrite Bluetooth commands to use the revision class * Rename EFirmwareType to FirmwareType * Integrate get_firmware_type into FirmwareType enum * Add missin byteorder flag for Python 3.9 * Shimmer3R (#36) * add 3r support * Update test_bt_commands.py * Update test_bt_commands.py * Update test_bt_commands.py * Update test_bt_commands.py * Update test_bt_commands.py * Update test_bt_commands.py * Update test_bt_commands.py * Reformat code and optimize imports * Refactor tests * Fix tests for new revision * Introduce dedicated Inquiry commands for different HW revisions * Reverse coupling from HardwareVersion to HardwareRevision * Implement RevisionRegistry class to look up revisions for HW versions * Introduce HardwareRevision class into ShimmerBinaryReader * Make BinaryReader hw revision available as property * Introduce HW revision into ShimmerReader, add unwrapping fn to Revision * Introduce revision class for ShimmerReader classes * Add licence and annotations import to new module * Introduce class-level variables to Registry for individual revisions * Add missing import for ESensorGroup to pyshimmer __init__ * Remove uses of GLOBAL variables and functions in tests * Remove uses of global channel functions and attributes from Dock API * Migrate DockAPI test to pytest * Remove further uses of channels attributes and functions * Remove global functions and attributes in dev.base and dev.channels * Update the Changelog * Update shimmer3r.py (#39) pressure and temp sensor format update --------- Co-authored-by: JongChern <jongchern@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pressure and temp sensor format update