Harmonize context managers and close methods - #41
Merged
Merged
Conversation
The close methods in the wrapper Serial classes have been removed. Furthermore, Dock and Bluetooth API won't close the underlying Serial class anymore when they themselves are closed. They didn't create the resource, so it doesn't make sense for them to close it. Furthermore, the context manager was removed from the Dock API. Since the Dock API class does not hold any resources that it itself created there is no need for the context manager. The serial instance should always be created within a with context, the same goes for the Bluetooth API. That way, they are always closed correctly and the with context then also handles closing of the serial interface at the right time. The examples were adjusted to reflect this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The close methods in the wrapper Serial classes have been removed. Furthermore, Dock and Bluetooth API won't close the underlying Serial class anymore when they themselves are closed. They didn't create the resource, so it doesn't make sense for them to close it.
Furthermore, the context manager was removed from the Dock API. Since the Dock API class does not hold any resources that it itself created there is no need for the context manager.
The serial instance should always be created within a with context, the same goes for the Bluetooth API. That way, they are always closed correctly and the with context then also handles closing of the serial interface at the right time. The examples were adjusted to reflect this.