Skip to content

fix(hubspot-web): add id=hs-script-loader to prevent duplicate script injection #3833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harsh-joshi99 wants to merge 4 commits into
base: main
Choose a base branch
from
+14 −1
Open

fix(hubspot-web): add id=hs-script-loader to prevent duplicate script injection #3833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
939715c
fix(hubspot-web): add id=hs-script-loader to prevent duplicate script…
harsh-joshi99 Jun 16, 2026
46acb48
test(hubspot-web): assert exactly one hs-script-loader script with co…
harsh-joshi99 Jun 16, 2026
efc5c4f
test(hubspot-web): assert literal injected src via getAttribute
harsh-joshi99 Jun 17, 2026
37d64e6
Merge branch 'main' into fix/hubspot-web-script-loader-id
harsh-joshi99 Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/browser-destinations/destinations/hubspot-web/src/__tests__/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,19 @@ describe('Hubspot Web (Actions)', () => {
expect(window.hbspt).toBeUndefined()
})

test('loads hubspot script with id=hs-script-loader to prevent duplicate script injection', async () => {
const [event] = await hubspotDestination({
portalId: '12345',
subscriptions
})

await event.load(Context.system(), {} as Analytics)

const loaderScripts = Array.from(document.querySelectorAll<HTMLScriptElement>('script#hs-script-loader'))
expect(loaderScripts).toHaveLength(1)
expect(loaderScripts[0].getAttribute('src')).toBe('https://js.hs-scripts.com/12345.js')
})
Comment thread
harsh-joshi99 marked this conversation as resolved.
Comment on lines +40 to +51

test('loads hubspot analytics with EU script', async () => {
const [event] = await hubspotDestination({
portalId: '12345',
Expand Down
2 changes: 1 addition & 1 deletion packages/browser-destinations/destinations/hubspot-web/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export const destination: BrowserDestinationDefinition<Settings, Hubspot> = {
? 'https://js-eu1.hsforms.net/forms/v2.js'
: 'https://js.hsforms.net/forms/v2.js'

await deps.loadScript(scriptPath)
await deps.loadScript(scriptPath, { id: 'hs-script-loader' })
Comment thread
harsh-joshi99 marked this conversation as resolved.
if (settings.loadFormsSDK) {
Comment thread
harsh-joshi99 marked this conversation as resolved.
await deps.loadScript(formsScriptPath)
}
Expand Down