Revert "STRATCONN-4121 - [Customerio] - fix timestamp normalization occurring after isIsoDate gate" - #3934
Merged
joe-ayoub-segment merged 1 commit intoAug 10, 2026
Conversation
…ccurring…" This reverts commit c74623f.
Prithviraj-rathore-segment
approved these changes
Aug 10, 2026
varadarajan-tw
approved these changes
Aug 10, 2026
joe-ayoub-segment
deleted the
revert-3930-fix/customerio-timestamp-normalize-before-gate
branch
August 10, 2026 14:48
Contributor
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Reverts the prior change that normalized ISO timestamp fractional seconds before parsing, restoring the earlier Customer.io timestamp handling behavior.
Changes:
- Removed ISO fractional-second normalization helper and its usage in timestamp conversion logic.
- Restored prior
convertAttributeTimestampsbehavior that gates conversion viaisIsoDate(value)without pre-normalization. - Removed regression tests covering sub-millisecond ISO timestamps and
convertAttributeTimestampsconversion behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/destination-actions/src/destinations/customerio/utils.ts | Removes fractional-second normalization and reverts parsing/gating behavior for timestamps. |
| packages/destination-actions/src/destinations/customerio/tests/utils.test.ts | Deletes tests that asserted correct handling of sub-millisecond ISO timestamps and attribute timestamp conversion. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
|
|
||
| const maybeDate = dayjs.utc(normalizeIsoFractionalSeconds(value)) | ||
| const maybeDate = dayjs.utc(value) |
Comment on lines
+69
to
+73
| // Parse only ISO 8601 date formats in strict mode | ||
| const maybeDate = dayjs(value) | ||
|
|
||
| if (isIsoDate(value)) { | ||
| ;(clone[key] as unknown) = maybeDate.unix() |
| @@ -1,4 +1,4 @@ | |||
| import { convertAttributeTimestamps, convertValidTimestamp, resolveIdentifiers, isIsoDate } from '../utils' | |||
| import { convertValidTimestamp, resolveIdentifiers, isIsoDate } from '../utils' | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #3930