This repository was archived by the owner on Apr 3, 2024. It is now read-only.
fix(preferences): uniformize events import#287
Open
jean9696 wants to merge 3 commits intosegmentio:masterfrom
Open
fix(preferences): uniformize events import#287jean9696 wants to merge 3 commits intosegmentio:masterfrom
jean9696 wants to merge 3 commits intosegmentio:masterfrom
Conversation
Collaborator
|
@jean9696 Can you merge in the latest so we can merge this PR? Thank you. |
edsonjab
approved these changes
Nov 22, 2022
Author
|
@nd4p90x should be fine now |
Collaborator
|
@jean9696 Looks like we are out of sync again. Sorry for the delay, I promise we will get to it as soon as you update the branch. Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I found out that the import of 'events' is not uniformized. As I need to make an alias for
events(which is anodemodule), I think it can be nice to use only the default import