chore: update packages to latest and resolve security vulnerabilities - #6
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves and completes a set of dependency upgrades intended to resolve known NuGet vulnerabilities and make the solution build again after upstream API/transitive changes (notably in Agent Framework A2A hosting).
Changes:
- Updated centrally-managed package versions (including vulnerability-driven pins) in
Directory.Packages.props. - Updated the workshop service to use the renamed A2A endpoint mapping (
MapA2AJsonRpc) and adjusted Azure OpenAI client setup. - Added/updated supporting repo files (NuGet source mapping, Aspire AppHost config, docs, and ignore rules).
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/AgentEvalsWorkshop/Program.cs | Adds Azure OpenAI client configuration, wires up A2A server, and updates endpoint mapping to MapA2AJsonRpc. |
| src/AgentEvalsWorkshop.AppHost/Program.cs | Removes an unused/stale using. |
| src/AgentEvalsWorkshop.AppHost/aspire.config.json | Adds Aspire AppHost configuration file pointing to the AppHost project. |
| src/AgentEvalsWorkshop.AppHost/AgentEvalsWorkshop.AppHost.csproj | Updates Aspire AppHost SDK version and removes an AppHost package reference. |
| README.md | Updates the architecture diagram label for the Foundry model. |
| nuget.config | Introduces explicit NuGet source + package source mapping. |
| exercises/US1-taskadheranceeval.md | Updates the example eval-model value in documentation. |
| Directory.Packages.props | Upgrades/pins package versions centrally, including security-related pins and framework upgrades. |
| .gitignore | Adds .idea/ to ignored paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+19
to
+23
| var azureOpenAIClient = new AzureOpenAIClient( | ||
| endpoint, | ||
| new DefaultAzureCredential(), | ||
| new AzureOpenAIClientOptions(AzureOpenAIClientOptions.ServiceVersion.V2025_04_01_Preview) | ||
| { |
Comment on lines
55
to
60
| <PackageVersion Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="$(OpenTelemetryVersion)" /> | ||
| <PackageVersion Include="OpenTelemetry.Extensions.Hosting" Version="$(OpenTelemetryVersion)" /> | ||
| <PackageVersion Include="OpenTelemetry.Instrumentation.AspNetCore" Version="$(OpenTelemetryVersion)" /> | ||
| <PackageVersion Include="OpenTelemetry.Instrumentation.Http" Version="$(OpenTelemetryVersion)" /> | ||
| <PackageVersion Include="OpenTelemetry.Instrumentation.Runtime" Version="$(OpenTelemetryVersion)" /> | ||
| <PackageVersion Include="OpenTelemetry.Instrumentation.Runtime" Version="1.15.1" /> | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the accidentally-committed package update off
mainonto a branch.Security fixes (
dotnet list package --vulnerablenow clean)Package updates (Directory.Packages.props)
CentralPackageTransitivePinningEnabledso the Microsoft.OpenApi pin applies transitivelyBuild fixes from API/transitive changes
MapA2A->MapA2AJsonRpc(renamed/split in Agent Framework 1.13)using Humanizer.Localisation;in AppHostBuild succeeds (0 errors); no vulnerable packages remain.