Enable scheduled daily summaries by default

[sepo-agent-app]

Summary

• Enable agent-daily-summary.yml scheduled runs by default while keeping explicit disable overrides.
• Add a discussion footer command that disables future scheduled daily summaries for the current repository.
• Update docs and focused tests for the new default.

Verification

• npm --prefix .agent run build
• node --test dist/__tests__/schedule-policy.test.js dist/__tests__/scheduled-activity.test.js dist/__tests__/envelope.test.js from .agent
• git diff --check

Closes #286

Part of #314

[sepo-agent-app]

Sepo is dispatching follow-up automation.

Source	Next	Target	Round	Status
implement	review	PR #326	3 / 40	Dispatched

Reason: implementation succeeded; dispatching review

[sepo-agent-app]

Rubrics Review

Total Score	Verdict	Rubrics Scored
95	PASS	8

Dimension	Rubric	Result	Score	Evidence
coding_workflow / generic	Make surgical changes	pass	8/8	Diff is scoped to schedule-policy defaults, the daily-summary workflow footer, focused tests, and matching docs.
coding_workflow / generic	Reuse existing code	pass	8/8	Uses existing AGENT_SCHEDULE_POLICY, parseSchedulePolicy, getScheduleModeForWorkflow, and scheduled activity gate paths instead of adding a parallel enable/disable mechanism.
coding_style / generic	Prefer simple implementations	pass	7/7	Removes the special daily-summary default override in .agent/src/schedule-policy.ts and the shell resolver, letting the existing default skip_no_updates mode apply.
coding_workflow / generic	Keep docs in sync	pass	7/7	Updates README.md, .agent/docs/architecture/memory.md, .agent/docs/architecture/supported-workflows.md, and .agent/docs/customization/configuration-list.md to describe the new default and disable override.
coding_workflow / generic	Minimal defaults, native escape hatches	pass	8/8	Default becomes activity-aware scheduled execution; the escape hatch remains the native repository variable AGENT_SCHEDULE_POLICY with a workflow override.
coding_workflow / generic	Prefer explicit structured inputs	pass	7/7	Disable guidance uses the existing typed JSON contract: {"workflow_overrides":{"agent-daily-summary.yml":"disabled"}}.
coding_workflow / generic	Make user-facing automation idempotent	partial	5/7	The footer command uses gh variable set, which is rerunnable, but it replaces the full AGENT_SCHEDULE_POLICY body and does not warn users with existing schedule policy overrides that copy-pasting may overwrite them.
communication / generic	Write audience-first documentation	pass	6/7	README and workflow docs lead with the operational behavior: daily summaries run by default, skip when there is no activity, and can be disabled via policy.

Notes

• The implementation matches issue Enable daily summary by default and include disable instructions #286’s requested behavior: scheduled daily summaries are enabled by default, use activity-aware skipping, and posted discussions include a current-repository disable command.
• The strongest rubric alignment is reuse of the existing schedule policy abstraction and synchronized documentation/test coverage.
• Smallest useful follow-up: make the disable footer mention that repositories with an existing AGENT_SCHEDULE_POLICY should merge the agent-daily-summary.yml override into their current JSON rather than blindly replacing the variable.

Findings

• WARNING: The discussion footer’s gh variable set AGENT_SCHEDULE_POLICY --body '{"workflow_overrides":{"agent-daily-summary.yml":"disabled"}}' is idempotent for repeated disable attempts, but it can overwrite unrelated existing schedule policy settings. This is a rubric-specific concern under “Make user-facing automation idempotent,” not a blocker because the command matches the issue’s requested example and uses the current repository slug.

Final Rubric Verdict

PASS

[sepo-agent-app]

AI Review Synthesis

Dual-agent review by Claude and Codex.
Requested by @lolipopshock.

Summary of PR/Issue

PR #326 implements issue #286 as part of the stacked small-fixes orchestration in #314. It enables scheduled daily summaries by default while preserving the existing skip_no_updates behavior so empty activity windows still skip posting. It also adds a repository-specific gh variable set AGENT_SCHEDULE_POLICY command to daily summary discussion footers so users can disable future scheduled summaries. The diff updates the TypeScript and shell schedule-policy paths, focused tests, and matching user-facing docs.

Review

Overall, the implementation is narrow, well-tested, and matches the requested behavior. Codex and Claude found no blockers; the rubrics review passed with one non-blocking warning about the disable command replacing the whole schedule policy value.

Issue	Severity	Description
Disable command can overwrite existing schedule policy	WARNING	The footer command disables daily summaries by setting the full AGENT_SCHEDULE_POLICY body, which can replace unrelated existing schedule-policy overrides if copied as-is.
Empty base override constant is vestigial	INFO	BASE_SCHEDULE_WORKFLOW_OVERRIDES is now an empty object after removing the daily-summary default override; this is harmless cleanup, not required follow-up.

Progress

• The PR is grounded in issue Enable daily summary by default and include disable instructions #286 and parent orchestration issue batch small fixes #314.
• Existing reviewers verified the runtime behavior, docs, and tests; Codex reported npm --prefix .agent run build, focused node --test suites, and git diff --check passing.
• Current PR inline comments and review threads are empty, so there was nothing to resolve or minimize.
• No new inline comment was posted because the only warning is already clearly covered in the existing rubrics review comment.

Issue Details

Disable command can overwrite existing schedule policy

Cause: The new discussion footer suggests gh variable set AGENT_SCHEDULE_POLICY --body '{"workflow_overrides":{"agent-daily-summary.yml":"disabled"}}', which replaces the entire variable value rather than merging with any existing JSON.

Candidate solutions: Leave as-is because it matches the issue’s requested example, or add a short note telling users with an existing AGENT_SCHEDULE_POLICY to merge the agent-daily-summary.yml override into their current JSON.

Comments: This is a product/docs judgment rather than a correctness blocker; the command is rerunnable and repository-specific.

Empty base override constant is vestigial

Cause: Removing the daily-summary disabled default leaves BASE_SCHEDULE_WORKFLOW_OVERRIDES empty while DEFAULT_SCHEDULE_WORKFLOW_OVERRIDES still spreads it.

Candidate solutions: Keep it for structural consistency, or inline/remove it in a later cleanup.

Comments: Claude explicitly marked this harmless and not worth a follow-up unless the split becomes confusing.

Recommended Next Step

HUMAN_DECISION: the remaining concern is optional user-facing guidance about whether the disable command should warn about existing schedule-policy values, not required branch work.

Final Verdict

MINOR_ISSUES

Action Items

• No required branch-change work.