Feed deterministic suggestions to orchestrator planner#377
Feed deterministic suggestions to orchestrator planner#377sepo-agent-app[bot] wants to merge 4 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lolipopshock
left a comment
There was a problem hiding this comment.
@sepo-agent check comments
There was a problem hiding this comment.
I think there is a first high-level comment: the updates to the documentation is not in the right tone.
For example, after this update, there is no point talking about AGENT_AUTOMATION_MODE -- it's completely gone. Also it's very weird to write in the tone of
Planner-backed orchestration is the recommended public mode. The deterministic
transition table remains internal runtime policy: it is used as a planner
suggestion and as validation after the planner responds.
Since for the reader there is no reason for them to know this context. This could be a helpful technical detail but should not be surfaced to the audience.
| ORCHESTRATOR_SUGGESTED_DECISION: ${{ steps.preflight.outputs.suggested_decision }} | ||
| ORCHESTRATOR_SUGGESTED_NEXT_ACTION: ${{ steps.preflight.outputs.suggested_next_action }} | ||
| ORCHESTRATOR_SUGGESTED_REASON: ${{ steps.preflight.outputs.suggested_reason }} | ||
| ORCHESTRATOR_SUGGESTED_HANDOFF_CONTEXT: ${{ steps.preflight.outputs.suggested_handoff_context }} |
There was a problem hiding this comment.
I don wonder if there's a better way to pass variables between action steps. This seems so ugly ...
|
Checked. There are two unresolved, non-outdated threads, and both are valid.
Recommended next step: run a focused
|
@sepo-agent /orchestrate can you fix the first documentation issue? And the second point is about a more general issue? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@sepo-agent /answer why does this variable should be completely removed from the corresponding files right? |
|
Yes, for the public/user-facing surface, that variable should go away. The reason is that after this change, automation_mode:
description: "Post-action orchestration mode (agent public default; heuristics is a compatibility alias)"still teaches users that there are modes they should think about. That is exactly the wrong tone and product surface. I would handle it as:
So: yes for docs and public workflow surfaces; not necessarily a blind delete from every internal file in the same PR unless we also replace the internal compatibility path.
|
@sepo-agent /orchestrate |
This comment has been minimized.
This comment has been minimized.
|
Sepo pushed fixes for this PR. Branch:
|
|
Sepo is dispatching follow-up automation.
Reason: agent planner selected review: fix-pr completed successfully on the pull request, so one follow-up review is warranted to verify the public workflow/docs surface changes and ensure no regressions. |
Rubrics Review
Notes
Findings
Final Rubric VerdictPASS
|
AI Review Synthesis
Summary of PR/IssuePR #377 implements phase 1 of #367 by reframing the old public ReviewThe current reviewer artifacts converge on ship-ready status. Codex and the rubrics review report no blocking or warning findings; Claude’s remaining notes are optional cleanup or awareness items rather than required branch work.
Progress
Recommended Next Step
Final VerdictSHIP Action Items
|
Summary
computeDeterministicTransitionand add planner-facing deterministic suggestion generation.ORCHESTRATOR_SUGGESTED_*fields from orchestrator preflight into the planner prompt while keeping runtime validation mandatory.heuristicsas a compatibility alias.Tests
npm run buildnode --test dist/__tests__/handoff.test.jsnode --test dist/__tests__/orchestrator-preflight-cli.test.jsnode --test dist/__tests__/envelope.test.jsnode --test dist/__tests__/orchestrate-handoff-cli.test.jsgit diff --checkCloses #367