[INT-1487] [INT-1913] CUPS image futureproofing#13
Open
zachariaserlandsson wants to merge 2 commits into
Open
Conversation
SimonOsnes
approved these changes
May 8, 2026
SimonOsnes
left a comment
There was a problem hiding this comment.
Amazing!
Would this make it so cups can run on macs as well or is that problem not connected to this at all?
Contributor
Author
To be perfectly honest, wasn't event aware of this issue at all :') So it wouldn't necessarily fix it I'd say.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the
printerliontech-debt cleanup I decided to do a little facelift of this Docker image as well, seeing as it was quite outdated (based on Ubuntu 16 base image).Dockerfilelocalesapt-get package, shouldn't be needed anymore (UTF8included in base Ubuntu image nowadays).Dockerfile, instead of having it both there and in the separateinstall.shscript.tinianymore - instead usinginit: trueparameter when spinning up CUPS container fromprinterlion. Accomplishes the same thing - running process as PID 1, so that signal forwarding and reaping of zombie processes is done.sudo(run as root anyway, so not needed).