test(sync): fix OneDev import ordering regression - #164
Conversation
There was a problem hiding this comment.
Validator approval after policy checks for exact head 6f1ec59cc4bf51146ab602c836ea03ac4675d75a.
Ticket: ticket-154
Correlation ID: local-semcod-planfile-pr-164-ticket-154
Model: zai/glm-5.3
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). Small, bounded follow-up that moves a standard-library import above project imports to satisfy Ruff/OneDev I001, plus new ticket metadata files. No functional changes. All required protected checks (ci-loop, notify, freshness, governance enforce/remote lifecycle, tests 3.10/3.13) pass; required_checks_passed is true. Changed files fall within the intent's allowedPaths.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: 2aca3812a586ebae637da10f5e7c00f53ad5c67f...6f1ec59cc4bf51146ab602c836ea03ac4675d75a
Change digest: 0a0616ddf9ab72d39ba71cdbc8263f9d5aee29b20eddd2440703a3daadda79f6
Score: 56/100 (M), estimated 51 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":93,"base_sha":"2aca3812a586ebae637da10f5e7c00f53ad5c67f","binary_files":0,"categories":{"configuration":1,"docs":1,"tests":1},"change_digest":"0a0616ddf9ab72d39ba71cdbc8263f9d5aee29b20eddd2440703a3daadda79f6","comparison":"2aca3812a586ebae637da10f5e7c00f53ad5c67f...6f1ec59cc4bf51146ab602c836ea03ac4675d75a","deletions":1,"file_count":3,"files":["project/ticket-154/README.md","project/ticket-154/intent.json","tests/test_sync_routing.py"],"head_sha":"6f1ec59cc4bf51146ab602c836ea03ac4675d75a","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":4,"delivery":4,"scope":2,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":51,"within_budget":false},"impact":{"components":["errors","project","tests"],"files":["errors/0","project/ticket-154/README.md","project/ticket-154/intent.json","tests/test_sync_routing.py"],"public_interfaces":[],"runtime_dependencies":1},"schema":"subactor.ticket-radar/v1","score":56,"split":{"parts":[{"estimated_minutes":14,"name":"Implement errors","scope":["errors"]},{"estimated_minutes":14,"name":"Implement project","scope":["project"]},{"estimated_minutes":14,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-154"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-154: test(sync): fix OneDev import ordering regression</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,47 97,53 79,85 59,71 31,53" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 51m</text></svg>DECISION D-154-2045
TICKET ticket-154
HEAD_SHA 6f1ec59cc4bf51146ab602c836ea03ac4675d75a
CORRELATION_ID local-semcod-planfile-pr-164-ticket-154
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["notify=PASS","governance / enforce=PASS","test (3.13)=PASS","governance / remote lifecycle=PASS","test (3.10)=PASS","freshness=PASS","ci-loop=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["ci-loop","notify","freshness","governance / remote lifecycle","governance / enforce","test (3.10)","test (3.13)"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/planfile","pull_request":164,"head_sha":"6f1ec59cc4bf51146ab602c836ea03ac4675d75a","base_sha":"2aca3812a586ebae637da10f5e7c00f53ad5c67f","diff_sha256":"08903b9f3412c5f4d7789669867b8ecb75bf0ee165ee670621a7be0ac244d656"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["project/ticket-154/README.md","project/ticket-154/intent.json","tests/test_sync_routing.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"2aca3812a586ebae637da10f5e7c00f53ad5c67f","head_sha":"6f1ec59cc4bf51146ab602c836ea03ac4675d75a","change_digest":"0a0616ddf9ab72d39ba71cdbc8263f9d5aee29b20eddd2440703a3daadda79f6","score":56,"complexity":"M","estimated_minutes":51,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
OneDev reported I001 after PR162 because the new regression test placed a standard-library import below project imports. Reorder that import without changing test or runtime behavior.
Validation: exact changed-file Ruff gate passed; 49 focused tests passed; governance 0 errors/0 warnings. Require a successful OneDev verification before publishing this follow-up.
Closes #163