refactor(logging): extract shared error-context handling from error and critical (ticket-032) - #90
Merged
Merged
Conversation
…nd critical (PLF-037) Co-authored-by: Koru Agent <agent@coru.dev>
…cal (PLF-037) Co-authored-by: Koru Agent <agent@coru.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the code2llm
Data Clumpsmell (error, message, selfrepeated acrossPprefactLogger.errorand.critical) by extracting a single_log_with_error_context(level, message, error, **kwargs)helper:errorandcriticalbecome one-line delegationserror_type/error_message/tracebackcontext block now lives in one placetests/test_logging.py): context populated for both levels, absent without an exception, extra kwargs preservedMirrors the same fix already applied on the
ticket/001-cqrs-event-sourcingbranch (6faeb59), rebased cleanly onto main.Verification
.venv/bin/python -m pytest tests/(uv, worktree-local env): 129 passed, 1 skipped (pre-existing diskcache skip; baseline on base was 125 passed + these 4 tests)ruff check src/prefact/logging/ tests/test_logging.py: 13 findings vs 13 on base — no new violations; remaining UP-rule findings pre-date this changeerror/criticalsignatures unchanged)Closes #32 (PLF-037)