Merged
Conversation
Owner
semnil
commented
Mar 26, 2026
semnil
commented
- Change mix_idx field to atomic_size_t to prevent data races between the audio thread (read) and UI thread (read-write)
- Use atomic_load/atomic_store/atomic_init for all mix_idx accesses
- Load mix_idx into a local var in mt2s_disconnect to avoid TOCTOU
- Add null/bounds guard at the start of mt2s_connect
- Cast literal 1 to size_t before shifting to avoid UB in bit-shift
semnil
force-pushed
the
fix/atomic-mix-idx-and-plugin-support
branch
from
3a6be1a to
fe1116c
Compare
semnil
changed the title
- Change mix_idx field to atomic_size_t to prevent data races between the audio thread (read) and UI thread (read-write) - Use atomic_load/atomic_store/atomic_init for all mix_idx accesses - Load mix_idx into a local var in mt2s_disconnect to avoid TOCTOU - Add null/bounds guard at the start of mt2s_connect - Cast literal 1 to size_t before shifting to avoid UB in bit-shift
This reverts commit daa0dc1.
…omic.h Guard stdatomic.h with #ifndef _MSC_VER and provide an MSVC-compatible fallback using volatile size_t with inline wrapper functions. This avoids requiring C11 mode in the OBS MSVC build config while maintaining source-level compatibility with atomic_init/load/store.
semnil
force-pushed
the
fix/atomic-mix-idx-and-plugin-support
branch
from
fe1116c to
1e894f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.