Merged
Conversation
The hashFiles function was failing on macOS with "Fail to hash files under directory" error. Using setup-python's built-in pip caching is more reliable and works consistently across all platforms.
…sues
- test_basic_workflow.py:
- Use return_value instead of side_effect for unlimited mock responses
- Simplify tests to focus on what can be tested with mocks
- Handle WebSocketError and WebSocketTimeoutError appropriately
- test_error_scenarios.py:
- Add ConfigurationError to expected exceptions
- Fix symbol validation tests (use alphanumeric symbols)
- Update TvDatafeedLive tests to check correct API methods
- Fix connection error tests to handle lazy connection
- test_live_feed_workflow.py:
- Rewrite all tests to use correct TvDatafeedLive API:
- new_seis(), del_seis() instead of start_live_feed()
- new_consumer(), del_consumer() for callbacks
- del_tvdatafeed() instead of stop_live_feed()
- Add proper cleanup in fixtures
- Test SEIS and Consumer management properly
The new_seis() method calls search_symbol() internally which makes HTTP requests to TradingView. Added mock for requests.get to prevent real network calls and 403 errors during tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.