Skip to content

Remove patient-specific settings, catalogs and objects on uninstall#118

Open
xispa wants to merge 10 commits into
masterfrom
fix-uninstall
Open

Remove patient-specific settings, catalogs and objects on uninstall#118
xispa wants to merge 10 commits into
masterfrom
fix-uninstall

Conversation

@xispa

@xispa xispa commented Feb 25, 2025

Copy link
Copy Markdown
Member

Description of the issue/feature this PR addresses

This Pull Request ensures that senaite.patient product can be uninstalled cleanly.

Current behavior before PR

Artifacts and data specific of senaite.patient are present after uninstall

Desired behavior after PR is merged

Artifacts and data specific of `senaite.patient are not present after uninstall

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa requested a review from ramonski February 25, 2025 17:21
@xispa xispa marked this pull request as draft February 25, 2025 17:42

@ramonski ramonski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this cleanup

@ramonski

Copy link
Copy Markdown
Contributor

Oh apologies, still work in progress here. Is something missing?

@xispa

xispa commented Feb 25, 2025

Copy link
Copy Markdown
Member Author

Oh apologies, still work in progress here. Is something missing?

Yes, tests are no passing because of the workaround I've done with _catalogs variable in Patient content type. Will open another PR (to be merged before this one) to make the product compatible with senaite/senaite.core#2662 and rely on registry instead of _catalogs attribute.

@ramonski

Copy link
Copy Markdown
Contributor

Ah ok, I actually missed the failing tests here.
Probably we should consider own Catalog Queue Processors per content type instead of this _catalogs attribute and drop the multiplexer completely

@xispa

xispa commented Feb 26, 2025

Copy link
Copy Markdown
Member Author

Ah ok, I actually missed the failing tests here. Probably we should consider own Catalog Queue Processors per content type instead of this _catalogs attribute and drop the multiplexer completely

Since senaite/senaite.core#2662 , we rely on a setting in the registry (catalog_mappings). We still support _catalogs for backwards compatibility though.

@xispa xispa marked this pull request as ready for review February 27, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants