Fix to ensure age can be saved even if estimated birthdate is set#132
Closed
nnpvaan wants to merge 1 commit into
Closed
Fix to ensure age can be saved even if estimated birthdate is set#132nnpvaan wants to merge 1 commit into
nnpvaan wants to merge 1 commit into
Conversation
nnpvaan
force-pushed
the
fix-age-requires-estimated-birthdate
branch
from
f16dc93 to
c0eabfe
Compare
nnpvaan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Fix issue where
ageis saved even whenestimated_birthdateis set.Current behavior before PR
In some cases, the
agefield is set before theestimated_birthdateis assigned.This causes the
agevalue to be stored even though noestimated_birthdateexists, leading to inconsistent data.Desired behavior after PR is merged
Automatically mark estimated_birthdate as True when age is set, ensuring that the age field is always stored correctly
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.