wip(agent): subagent empty tool allowlist fail-open (Option<HashSet> allowlist) (tinyhumansai#4452) - #5
Closed
senamakel wants to merge 1 commit into
Closed
wip(agent): subagent empty tool allowlist fail-open (Option<HashSet> allowlist) (tinyhumansai#4452)#5senamakel wants to merge 1 commit into
senamakel wants to merge 1 commit into
Conversation
…ed by spend limit) Uncommitted implementation salvaged from the parity workflow worktree after the subagent was killed by the monthly spend limit before it could verify, commit, and open a PR. NOT yet build-verified — needs a cargo check pass and test run before merge. Preserved so the work is not lost. Ref: tinyhumansai#4452 Claude-Session: https://claude.ai/code/session_019j5TLsRLHsM3kqAYFyH4hR
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Owner
Author
|
Superseded — re-implementing fresh on the post-merge base (upstream tinyhumansai#4473 landed, changing the seam). A new build-verified PR will replace this. |
M3gA-Mind
added a commit
that referenced
this pull request
Sep 1, 2026
…ight specs
Both drive the real app in a browser against a live openhuman-core. Neither
mocks transport.
brain-embedding-truthfulness.spec.ts seeds a folder source through the core's
own RPCs and reads memory_sources_status_list to confirm chunks_pending > 0
BEFORE asserting on the UI, so a workspace with a healthy embedder skips with a
reason instead of passing vacuously. Absolute mkdtemp paths throughout: a
relative source path resolves against the core's working directory.
Fixed against the live core on the first run: memory_sources_sync takes
source_id (not id), and memory_sources_add returns { source }.
KNOWN: this spec cannot pass in a sandbox with no GitHub release access. The
memory engine is a downloaded cdylib and memory_sources_sync fails with
"module 'tinymemory' could not be loaded". Reported as undrivable rather than
re-done in jsdom. See ~/tinyhuman/bugs/W6-ui-bugs.md #5.
notifications-feed-interaction.spec.ts covers the system-events feed, which no
core RPC can reach — those items arrive over socket.io into a redux-persist
slice. It seeds the slice through the app's own persistence keys, exactly what a
returning user's browser holds, and asserts on rendered text, aria-selected on
the chip tablist, the unread count, and survival of a reload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo check, fix any compile errors, and open the PR. Preserved so the work isn't lost.Addresses tinyhumansai#4452 (see that issue for problem/fix plan/acceptance criteria).
TODO before merge:
cargo check --lib+ targeted tests, resolve any compile errors, confirm acceptance criteria. Do not merge until green.https://claude.ai/code/session_019j5TLsRLHsM3kqAYFyH4hR