Skip to content

refactor(core): move state-fingerprint helpers to block_executor submodule#796

Merged
github-actions[bot] merged 1 commit into
mainfrom
refactor/block-executor-fingerprint-module
Jun 6, 2026
Merged

refactor(core): move state-fingerprint helpers to block_executor submodule#796
github-actions[bot] merged 1 commit into
mainfrom
refactor/block-executor-fingerprint-module

Conversation

@satyakwok
Copy link
Copy Markdown
Member

First step of breaking up the sentrix-core monolith (16k LOC) for debuggability, lowest-risk first: a pure module-split within the crate — zero crate boundary, so no serialization/API surface where a determinism bug could hide.

What moved

emit_apply_profile, emit_state_fingerprint, compute_state_fingerprint, StateComponents, state_componentsblock_executor/fingerprint.rs (continuing the existing block_executor/{evm,validate} submodule pattern). All are debug/observability helpers gated behind SENTRIX_STATE_FINGERPRINT / SENTRIX_APPLY_PROFILE; they never feed consensus.

Safety

  • Pure code motion — function bodies are byte-identical, no logic change.
  • state_components + StateComponents stay pub (re-exported at the module path, used by the bin state command); the rest are pub(crate).
  • Un-scrambles doc comments that had drifted above the wrong function.

Verification

  • cargo check --workspace -D warnings clean (bin re-export resolves).
  • cargo test -p sentrix-core: 273 passed, 0 failed (unchanged from before the move).

…odule

Pure code motion, no behavior change: emit_apply_profile, emit_state_fingerprint, compute_state_fingerprint, StateComponents and state_components move out of the 3390-line block_executor.rs into block_executor/fingerprint.rs (continuing the existing block_executor/{evm,validate} split). These are debug/observability helpers gated behind SENTRIX_STATE_FINGERPRINT / SENTRIX_APPLY_PROFILE — they never feed consensus. state_components + StateComponents stay pub (re-exported, used by the bin's state command); the rest are pub(crate). Also un-scrambles the doc comments that had drifted above the wrong function. cargo check --workspace -D warnings clean; sentrix-core 273 tests pass (unchanged).
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 6, 2026

Warning

Review limit reached

@satyakwok, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 8 minutes and 11 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5f71777a-a034-44c8-ba44-7919d199a3eb

📥 Commits

Reviewing files that changed from the base of the PR and between 07d8def and e82b2d9.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock, !**/*.lock
📒 Files selected for processing (3)
  • Cargo.toml
  • crates/sentrix-core/src/block_executor.rs
  • crates/sentrix-core/src/block_executor/fingerprint.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/block-executor-fingerprint-module

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot enabled auto-merge (squash) June 6, 2026 06:46
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions github-actions Bot merged commit fd264e8 into main Jun 6, 2026
19 checks passed
@satyakwok satyakwok self-assigned this Jun 6, 2026
@satyakwok satyakwok deleted the refactor/block-executor-fingerprint-module branch June 6, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant