feat: pass --wait when deleting compute-envs during overwrite#267
Open
feat: pass --wait when deleting compute-envs during overwrite#267
Conversation
When seqerakit deletes a compute environment as part of an overwrite operation, it now appends --wait to the tw CLI args so the delete blocks until the CE is fully removed before re-creating it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Rob Syme <rob.syme@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on_exists: overwritedeletes a compute environment, appends--waitto thetw compute-envs deletecommandContext
Forge CE deletion is async (~2 minutes). seqerakit's overwrite flow deletes the CE and immediately creates the replacement, which fails because the old CE is still in
DELETINGstatus. Adding--waitmakes the delete call block until the CE is gone.Depends on: seqeralabs/tower-cli#593 — the tower-cli change must ship first.
Related: FD-7252
Test plan
test_delete_resource_compute_envs_includes_wait: verifies--waitis appended for compute-envstest_delete_resource_credentials_does_not_include_wait: verifies other resources are unaffected🤖 Generated with Claude Code