feat: Make server listening port configurable via WAVE_SERVER_PORT mn env var#1029
Open
feat: Make server listening port configurable via WAVE_SERVER_PORT mn env var#1029
Conversation
bebosudo
requested review from
MichaelTansiniSeqera,
Copilot,
gavinelder and
munishchouhan
There was a problem hiding this comment.
Pull request overview
This PR updates Micronaut configuration so the Wave server listening port can be set explicitly via the WAVE_SERVER_PORT environment variable, rather than relying on Micronaut’s implicit env-var-to-property mapping.
Changes:
- Make
micronaut.server.portresolve fromWAVE_SERVER_PORTwith a9090default.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows users to configure the wave server listening port using the explicit variable
WAVE_SERVER_PORTinstead of using the implicit micronaut variableMICRONAUT_SERVER_PORT.