Skip to content

fix: Finding selection support navigate to source file for findings without code flows - #3

Merged
misonijnik merged 1 commit into
seqra:mainfrom
ddrpa:fix-location-lines
Jul 17, 2026
Merged

fix: Finding selection support navigate to source file for findings without code flows#3
misonijnik merged 1 commit into
seqra:mainfrom
ddrpa:fix-location-lines

Conversation

@ddrpa

@ddrpa ddrpa commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

When a SARIF finding has no codeFlows (common for pattern-match rules like hardcoded credentials or stacktrace-printing), clicking it in the Findings tree does not navigate the code panel to the finding's source file. The editor stays on whatever file was previously selected.

Changes

  • Add line?: number to Finding
  • Parse locations[0].physicalLocation.region.startLine into finding.line
  • Include finding.file in the referenced set alongside flow-step files
  • Add f?.file ?? before get().activeFile
  • When pathDecorations is empty but finding.line exists, scroll to and highlight the primary line

@misonijnik misonijnik changed the title Finding selection support navigate to source file for findings without code flows fix: Finding selection support navigate to source file for findings without code flows Jul 17, 2026
@misonijnik
misonijnik merged commit fdeb572 into seqra:main Jul 17, 2026
1 check passed
@misonijnik

Copy link
Copy Markdown
Member

@ddrpa Thanks for fixing that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants