refactor: migrate to pyramids-gis 0.32 and cleopatra 0.17 APIs#176
Open
MAfarrag wants to merge 5 commits into
Open
refactor: migrate to pyramids-gis 0.32 and cleopatra 0.17 APIs#176MAfarrag wants to merge 5 commits into
MAfarrag wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates all calls to the
pyramids-gisandcleopatralibraries to their latest APIs (0.32.0 and 0.17.0) and bumps both pins inpyproject.toml.pyramids-gis 0.32
pyramids.multidataset.MultiDatasetwithpyramids.dataset.DatasetCollection(kept theDatacubealias).DatasetCollection.alignis no longer in-place by default; passinplace=TrueinInputs.prepare_inputsand capture the file names before in-place align/crop clear the collection's file list.Dataset.dataset_likedropped thedriverkwarg and requires a pyramidsDatasetas source; wrap the raw gdal dataset inParameters.stats()now returns exact band statistics instead of GDAL's sampled values; updated the lumped-parameter test expectations (verified against independently computed spatial means of the valid cells).pyramids.raster.RasterAPI (fill,apply,align,crop)..aux.xmlstatistics sidecar files generated during tests.cleopatra 0.17
ArrayGlyph.animateiterates the first axis; move the time axis to the front inplot_distributed_results.pointsarray ([id, cell_row, cell_col]) instead of a DataFrame.Catchment.save_animationas a thin wrapper aroundArrayGlyph.save_animation(it had no implementation since the plot module moved to cleopatra).Bug fix surfaced by the upgrade
plot_distributed_resultscomparedFlowAccArragainst the no-data value, butread_flow_accconverts no-data cells to NaN, so the masks never matched and ±3.4e38 sentinels leaked into the plots. All masks now usenp.isnan.Testing
-m "not fig_share").plot_distributed_results(precipitation with gauges, soil moisture) →save_animationproduced a valid GIF.