Fix device list not being updated - #38
Draft
dsouza95 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR fixes #36. By calling PA_terminate on every GetDevices call, we ensure the device list is properly updated. I modified the devices example to call GetDevices every 5 seconds, so it is easy to add/remove any device and verify this behavior (not sure if that should be another example, or if that is needed at all).
I tested this fix on an Ubuntu 22.04, but didn´t manage to build on my Windows 10 (tried Msys2 MinGW64 and Cygwin). Is there a recommended setup for Windows builds?