Fix PISA top_n_count to compute BM25 scores and maintain top-k#1
Open
MBkkt wants to merge 1 commit into
Open
Conversation
Previously, TOP_N_COUNT commands for PISA did not compute BM25 scores (union path used unscored cursors) and did not maintain top-k results. - Intersection/single-term: use scored_and_query + std::nth_element for top-k - Union: inline ranked_or_query loop with scored cursors, topk_queue, and document counting in a single pass https://claude.ai/code/session_01Ttc55r4opG456zn7i8wLWf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scored_and_queryreturns all scored results; addedstd::nth_elementto compute top-k, count from.size()ranked_or_queryloop withtopk_queue+count++in a single pass using scored cursors for BM25Previously the union path used unscored
make_cursors(no BM25) and neither path maintained top-k results.Test plan
https://claude.ai/code/session_01Ttc55r4opG456zn7i8wLWf