feat: Playwright e2e smoke suite guarding the a11y and island behaviors#68
Merged
Conversation
Adds 9 chromium smoke tests (e2e/) covering the six behaviors with no regression net: catalog filter + aria-live announcements, URL state restore, lazy variant face-swap, keyboard tooltips, variant cycling pause + prefers-reduced-motion, copy-link, and script rebinding across view transitions. Tests are data-driven (names/values read from the page and variant-icons.json) so weekly data bumps can't break them. Runs inside the required ci check after Build (cached chromium install, report artifact on failure), so it also gates the weekly data auto-merge. vitest.config.ts scopes vitest to tests/ so it never collects e2e specs. Claude-Session: https://claude.ai/code/session_013ga8yb2vDELdU9x9zZPDtA
seriouslysean
marked this pull request as ready for review
July 14, 2026 18:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the deferred browser-test regression net from the audit follow-ups: a 9-test Playwright (chromium-only) smoke suite covering the six a11y/island behaviors that previously had no automated coverage, wired into the required
cicheck so it also gates the weekly data auto-merge.Tests (e2e/, 4 specs, 9 tests)
#catalog-status(role=status) announces count/no-match; Enter writes?q=and a fresh load restores it; lazy/variant-icons.jsonfetch + card face-swap, reverting todata-default-name:focus-withinreveals the popup on a non-cycling slot; grid a11y contract (visually-hidden summary, no role override, focusable triggers)page.clock) proves the 1500ms cycle advances, pauses on hover, and never runs underprefers-reduced-motionastro:page-loadand the pager navigates (URL shape only — slugs are data-dependent)All assertions read expected values from the page's own data attributes / the manifest, so weekly vanilla-data bumps can't break them.
Infra
playwright.config.ts—astro previewwebServer on 4321 (build-first), retries/workers/HTML report in CI onlyvitest.config.ts— scopes vitest totests/**so it never collectse2e/*.spec.ts. Local note: configless vitest was also collecting 221 duplicate suites from stale.claude/worktrees/copies (the "2825 tests" figure); the real suite is 32 files / 408 tests, all still collected — CI counts are unchanged~/.cache/ms-playwright→ install chromium →npm run test:e2e→ report artifact on failure (7d). New actions SHA-pinned. ~50–70s on cache hittsconfig.node.jsoninclude; oxlint/oxfmt/git ignoreplaywright-report/test-resultsnpm run test:e2ewith the build-first gotchaVerification
npm test(32 files, 408) / build — all greennpm run test:e2e— 9/9;--repeat-each=3— 27/27, zero flakesOut of scope
Visual regression, cross-browser matrix, axe-core, data-dependent assertions.
https://claude.ai/code/session_013ga8yb2vDELdU9x9zZPDtA