Merged
Conversation
* This is the initial sketch of how a custom theming of the charts has to be done. The goal is to simplify theming so it supports color deficiency themes, and many others.
* The goal is to prepare it for combined indicators its a bit of an annoying exercise at this stage. Maybe a separate branch is warranted.
* These functions are using the charting variables, and needed some tweaks. The bars on the trading_volume() have been removed as they are redundant information wise.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #28 +/- ##
==========================================
+ Coverage 96.25% 96.26% +0.01%
==========================================
Files 271 272 +1
Lines 12661 12996 +335
==========================================
+ Hits 12187 12511 +324
- Misses 474 485 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* If the indicator() were called without chart() it would fail due to incorrect variable passing.
* Functions nows includes grid-lines and colorway.
* This will ensure alignment with the last values.
* A similar implementation were made in
{cryptoQuote}: https://github.com/serkor1/cryptoQuotes/blob/main/R/chart_quote.R
* It will now always reformat numbers higher than 999 regardless of series size.
* It will now do a direct search instead of a negated search. * The numbers are now properly formatted to avoid double precision when a matrix is passed.
* The current implementation is a greedy match using grep. - For DX it will include the 'idx' column. This will be fixed "later".
* The <data.frame> is now passed in a subsetted version to add_last_values(), instead of searching for the columns.
* Similar to hawks and doves.
* It is now called as set_theme$theme_name()
- Much cleaner solution.
* Simple and straight-forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 What?
This PR introduces changes to the
<plotly>-methods and the overall charting API. Specifically:Some of the
<plotly>-methods have been streamlined and simplified. Thetrading_volume(), for example, have had removed its legends for the bars.