Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 176 176
=========================================
Hits 176 176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR refactors the Repository interface to use value semantics instead of pointer semantics for the Flag type. The change simplifies the API by passing and returning Flag structs by value rather than by pointer.
Key changes:
- Updated the
Repositoryinterface to accept and returnFlagvalues instead of pointers - Modified the
MemoryRepositoryimplementation to storeFlagvalues in the map - Updated all callers to pass
Flagvalues instead of pointers
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/flags/repository.go | Changed interface methods from pointer-based (*Flag) to value-based (Flag) signatures |
| internal/flags/memory.go | Updated implementation to store and return Flag values, changed map type from map[string]*Flag to map[string]Flag |
| internal/flags/service.go | Updated Create method to pass flag by value instead of &flag |
| internal/flags/memory_test.go | Updated test data initialization from pointer literals to value literals |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.