Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
- Coverage 92.42% 92.22% -0.20%
==========================================
Files 6 6
Lines 198 193 -5
==========================================
- Hits 183 178 -5
Misses 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR removes unused fields and types from the feature flags system, specifically eliminating versioning, rollout functionality, and override capabilities that were not being actively used.
- Removed
Versionfield fromFlagandEvalResultstructs and related response bodies - Removed
Rollout,Override, andOverrideScopetypes along with associated evaluation reasons - Updated all tests and service implementations to reflect the simplified data model
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/flags/types.go | Removed Version field from Flag and EvalResult, removed Rollout field from Rule, deleted Rollout, Override, and OverrideScope types, and removed ReasonUserOverride and ReasonTenantOverride constants |
| internal/flags/service.go | Removed version initialization logic from Create method and removed version assignment in Evaluate method |
| internal/flags/service_test.go | Removed version assertion from TestService_Create |
| internal/flags/memory_test.go | Removed Version field initialization from test flag fixtures |
| internal/handler/models.go | Removed Version field from CreateFlagResponseBody and EvalResultBody response structures |
| internal/handler/handler.go | Removed Version field assignment from CreateFlagResponse |
| internal/handler/mapper.go | Removed Version field mapping in ToEvalResultBody function |
| internal/handler/mapper_test.go | Removed Version field from test fixture and removed version assertion from test |
| internal/handler/handler_test.go | Removed version assertion from TestHandler_CreateFlag |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.