Skip to content

Remove unused things - #9

Merged
serroba merged 1 commit into
mainfrom
dev
Jan 2, 2026
Merged

Remove unused things#9
serroba merged 1 commit into
mainfrom
dev

Conversation

@serroba

@serroba serroba commented Jan 2, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings January 2, 2026 06:38
@serroba
serroba merged commit dfbb2f7 into main Jan 2, 2026
5 checks passed
@serroba
serroba deleted the dev branch January 2, 2026 06:38
@codecov

codecov Bot commented Jan 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.22%. Comparing base (1910d75) to head (747a94f).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   92.42%   92.22%   -0.20%     
==========================================
  Files           6        6              
  Lines         198      193       -5     
==========================================
- Hits          183      178       -5     
  Misses         15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes unused fields and types from the feature flags system, specifically eliminating versioning, rollout functionality, and override capabilities that were not being actively used.

  • Removed Version field from Flag and EvalResult structs and related response bodies
  • Removed Rollout, Override, and OverrideScope types along with associated evaluation reasons
  • Updated all tests and service implementations to reflect the simplified data model

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/flags/types.go Removed Version field from Flag and EvalResult, removed Rollout field from Rule, deleted Rollout, Override, and OverrideScope types, and removed ReasonUserOverride and ReasonTenantOverride constants
internal/flags/service.go Removed version initialization logic from Create method and removed version assignment in Evaluate method
internal/flags/service_test.go Removed version assertion from TestService_Create
internal/flags/memory_test.go Removed Version field initialization from test flag fixtures
internal/handler/models.go Removed Version field from CreateFlagResponseBody and EvalResultBody response structures
internal/handler/handler.go Removed Version field assignment from CreateFlagResponse
internal/handler/mapper.go Removed Version field mapping in ToEvalResultBody function
internal/handler/mapper_test.go Removed Version field from test fixture and removed version assertion from test
internal/handler/handler_test.go Removed version assertion from TestHandler_CreateFlag

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants