Let embedder handle "maybe clone option into selectedcontent" algorithm#719
Merged
mrobinson merged 2 commits intoservo:mainfrom Jan 22, 2026
Merged
Let embedder handle "maybe clone option into selectedcontent" algorithm#719mrobinson merged 2 commits intoservo:mainfrom
mrobinson merged 2 commits intoservo:mainfrom
Conversation
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
simonwuelker
force-pushed
the
selectedcontent-fixes
branch
from
e03ecbf to
c5b938b
Compare
github-actions
bot
added
V-breaking
mrobinson
approved these changes
Jan 22, 2026
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Contributor
Author
|
servo/servo#42036 is approved. Can someone with release permissions merge this and then publish the new versions? |
github-actions
bot
added
V-non-breaking
Member
|
I've released the new versions. |
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Jan 22, 2026
Do not merge yet - we need to create a new html5ever release. The html5ever bump also includes encoding indicators, which we handle in the most minimal way possible here. They will be handled properly by #41730 Companion PR for servo/html5ever#719 --------- Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current way we track the enabled selectedcontent element of the nearest ancestor select is wrong (see #712 (comment)). This change moves most of the code for
maybe clone an option into selectedcontentintoTreeSink, removing the need to track said element.Hopefully the amount of code needed to provide a reasonable (yet still incorrect!) implementation of the new method in
rcdomis enough to convince everyone that we don't want to handle this inside html5ever - it needs very tight integration with the DOM, much more so than anything else we currently have.Merging this change will also require a new breaking release. It is unfortunate to bump the version again so soon, but the current version has major issues, see #560 (comment).
Part of #712
Companion PR for servo/servo#42036
cc @untitaker