Fix Node drop clobbering children
#725
Open
+100
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Node::drop` no longer clobbers nodes that have active external handles
Lucretiel
force-pushed
the
preserve-recursive-children
branch
from
bf66add to
f46fe24
Compare
Author
|
CI failure is some kind of job cancellation. |
Contributor
|
Ah, no need to worry about the SemVer check. That isn't working yet and doesn't block merging. |
github-actions
bot
added
V-non-breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node::dropno longer clobbers child nodes that have active external handles. It still takes care to drop iteratively rather than recursively, to avoid an unbounded stack growth. As an added benefit, may be marginally more performant, as it now can avoidborrow_muton theRefCell.Additionally add a regression test for this behavior.
Fixes #410